Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows build #30

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Fix windows build #30

merged 1 commit into from
Dec 6, 2023

Conversation

kostobog
Copy link

@kostobog kostobog commented Dec 6, 2023

Fix #29

@kostobog kostobog requested review from blcham and LaChope December 6, 2023 15:13
blcham
blcham approved these changes Dec 6, 2023
View reviewed changes
Copy link

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although quite ugly fix :)

@blcham blcham merged commit 5ac3f82 into main Dec 6, 2023
2 checks passed
@blcham blcham deleted the issues/29-cannot-build-in-windows branch December 17, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blcham blcham blcham approved these changes

@LaChope LaChope Awaiting requested review from LaChope

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot build in windows
2 participants
@kostobog @blcham